Thesharing commented on a change in pull request #16314:
URL: https://github.com/apache/flink/pull/16314#discussion_r661370236
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionPartitionLifecycleTest.java
##########
@@ -316,7 +317,10 @@ private JobVertex createNoOpJobVertex() {
return jobVertex;
}
- private static class TestingShuffleMaster implements
ShuffleMaster<ShuffleDescriptor> {
+ private static class TestingShuffleMaster
Review comment:
It's because the `ShuffleDescriptor` introduced in this
`TestShuffleMaster` refers to `ProducerDescriptor` and `ShuffleMaster`. But I
shouldn't make them serializable. Sorry for that. Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
