XComp commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r661412119
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/application/JarManifestParserTest.java
##########
@@ -157,6 +158,24 @@ public void
testFindOnlyEntryClassMultipleJarsWithSingleManifestEntry() throws I
is(equalTo(TestJob.class.getCanonicalName())));
}
+ @Test
+ public void testFindFirstManifestAttributeWithNoAttribute() throws
IOException {
+ assertThat(
+
JarManifestParser.findFirstManifestAttribute(TestJob.getTestJobJar()).isPresent(),
+ is(false));
+ }
+
+ @Test
+ public void testFindFirstManifestAttributeWithAttributes() throws
IOException {
+ Optional<String> optionalValue =
+ JarManifestParser.findFirstManifestAttribute(
+ TestJob.getTestJobJar(),
+ "some-attr",
Review comment:
I added the tests because I made the
`JarManifestParser.findFirstManifestAttribute` publicly accessible. Hence, I
thought of adding test cases for it might be good as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
