tillrohrmann commented on a change in pull request #16342: URL: https://github.com/apache/flink/pull/16342#discussion_r662897162
########## File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/DeadLettersActor.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rpc.akka; + +import org.apache.flink.runtime.rpc.akka.exceptions.AkkaRecipientUnreachableException; +import org.apache.flink.runtime.rpc.messages.Message; + +import akka.actor.AbstractActor; +import akka.actor.DeadLetter; +import akka.actor.Props; +import akka.actor.Status; +import akka.japi.pf.ReceiveBuilder; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Actor which listens to {@link akka.actor.DeadLetter} and responds with a failure if the message + * was a RPC. + */ +public class DeadLettersActor extends AbstractActor { + + private static final Logger LOG = LoggerFactory.getLogger(DeadLettersActor.class); + + @Override + public Receive createReceive() { + return new ReceiveBuilder().match(DeadLetter.class, this::handleDeadLetter).build(); + } + + private void handleDeadLetter(DeadLetter deadLetter) { + if (deadLetter.message() instanceof Message) { + if (deadLetter.sender().equals(getContext().getSystem().deadLetters())) { + LOG.debug( + "Could not deliver message {} with no sender to recipient {}. " + + "This indicates that the actor terminated unexpectedly.", Review comment: If a message has no sender, then it does not expect a result (e.g. when using `ActorRef.tell`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
