tillrohrmann commented on a change in pull request #16342:
URL: https://github.com/apache/flink/pull/16342#discussion_r662901704
##########
File path:
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java
##########
@@ -361,6 +363,30 @@ public void
testAkkaRpcServiceShutDownWithFailingRpcEndpoints() throws Exception
assertThat(akkaRpcService.getActorSystem().whenTerminated().isCompleted(),
is(true));
}
+ @Test
+ public void failsRpcResultImmediatelyIfEndpointIsStopped() throws
Exception {
Review comment:
The code looks identical but both tests test different things:
`AkkaRpcServiceTest#failsRpcResultImmediatelyIfEndpointIsStopped` tests that
the `RecipientUnreachableException` is thrown if the endpoint is in the same
`ActorSystem`. In contrast to that,
`RemoteAkkaRpcActorTest#failsRpcResultImmediatelyIfEndpointIsStopped` tests
that the same behaviour occurs if the endpoint is in a different `ActorSystem`
(e.g. remote communication is needed). In fact the former case is why I had to
change `AkkaInvocationHandler#resolveTimeoutException` because it only surfaced
as a `AskTimeoutException` with a special message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
