zentol commented on a change in pull request #16345:
URL: https://github.com/apache/flink/pull/16345#discussion_r663091576
##########
File path:
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcSystem.java
##########
@@ -86,8 +95,28 @@ static RpcSystem load() {
* @return loaded RpcSystem
*/
static RpcSystem load(Configuration config) {
- final ClassLoader classLoader = RpcSystem.class.getClassLoader();
- return ServiceLoader.load(RpcSystem.class,
classLoader).iterator().next();
+ try {
+ final ClassLoader classLoader = RpcSystem.class.getClassLoader();
+
+ final String tmpDirectory =
ConfigurationUtils.parseTempDirectories(config)[0];
+ final Path tempFile = Files.createFile(Paths.get(tmpDirectory,
"flink-rpc-akka.jar"));
+ IOUtils.copyBytes(
+ classLoader.getResourceAsStream("flink-rpc-akka.jar"),
+ Files.newOutputStream(tempFile));
+
+ final PluginLoader pluginLoader =
+ PluginLoader.create(
+ new PluginDescriptor(
+ "flink-rpc-akka",
+ new URL[] {tempFile.toUri().toURL()},
+ new String[0]),
+ classLoader,
+
CoreOptions.getPluginParentFirstLoaderPatterns(config));
Review comment:
oh yes a user messing with it breaks things big time. Since we are
dealing here with a mechanism that is not intended to be extended by the user
I'm +1 on using a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
