zentol commented on a change in pull request #16345:
URL: https://github.com/apache/flink/pull/16345#discussion_r663028363
##########
File path:
flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcSystem.java
##########
@@ -74,8 +87,39 @@ RpcServiceBuilder withExecutorConfiguration(
* @return loaded RpcSystem
*/
static RpcSystem load() {
- final ClassLoader classLoader = RpcSystem.class.getClassLoader();
- return ServiceLoader.load(RpcSystem.class,
classLoader).iterator().next();
+ return load(new Configuration());
+ }
+
+ /**
+ * Loads the RpcSystem.
+ *
+ * @return loaded RpcSystem
+ */
+ static RpcSystem load(Configuration config) {
+ try {
+ final ClassLoader classLoader = RpcSystem.class.getClassLoader();
+
+ final String tmpDirectory =
ConfigurationUtils.parseTempDirectories(config)[0];
+ final Path tempFile =
+ Files.createFile(
+ Paths.get(tmpDirectory, UUID.randomUUID() +
"_flink-rpc-akka.jar"));
Review comment:
No effort at all, and it would force all users of this method to depend
on flink-runtime (without which it would fail anyway).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
