zentol commented on a change in pull request #16332:
URL: https://github.com/apache/flink/pull/16332#discussion_r663141052



##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -243,3 +278,9 @@ jobs:
       inputs:
         targetPath: $(DEBUG_FILES_OUTPUT_DIR)
         artifact: logs-${{parameters.stage_name}}-$(DEBUG_FILES_NAME)
+    - script: |
+        mkdir -p $(TESTCONTAINER_CACHE_FOLDER)
+        docker save $(docker image ls --format "{{.Repository}}:{{.Tag}}" | 
grep -E -- "testcontainers|kafka|elasticsearch|postgres|mysql") -o 
$(TESTCONTAINER_CACHE_FOLDER)/cache.tar || true

Review comment:
       hmm...yes then it makes sense to have it as part of the key. But this 
does also mean that if we fetch an image a _different_  elasticsearch version 
that it will never be cached.
   Maybe we have to setup a convention such that all images we use must be 
listed in a specific .java file (/.sh file for the e2e tests), which we then 
use as a cache key.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to