zicat commented on a change in pull request #16163:
URL: https://github.com/apache/flink/pull/16163#discussion_r657706409
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/BridgingFunctionGenUtil.scala
##########
@@ -288,16 +290,39 @@ object BridgingFunctionGenUtil {
s"($externalResultTypeTerm) (${typeTerm(externalResultClassBoxed)})"
}
val externalResultTerm =
ctx.addReusableLocalVariable(externalResultTypeTerm, "externalResult")
+ val externalCode =
+ s"""
+ |${externalOperands.zip(argumentDataTypes)
+ .map{case (element, dataType) => {
+ element match {
+ case external: ExternalGeneratedExpression
+ if !isInternal(dataType) &&
!element.resultType.isInstanceOf[StructuredType]
Review comment:
I'm sorry for not thinking about it, dataType == element.dataType is
better that means original dataType is same with converter.toInternalOrNull
dataType, also means using externalCode & externalTerm is well.
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/ExternalGeneratedExpression.scala
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen
+
+import org.apache.flink.table.types.DataType
+import org.apache.flink.table.types.logical.LogicalType
+
+/**
+ * Describes a external generated expression.
+ *
+ * @param dataType type of the resultTerm
+ * @param internalTerm term to access the internal result of the expression
+ * @param externalTerm term to access the external result of the expression
+ * @param nullTerm boolean term that indicates if expression is null
+ * @param internalCode code necessary to produce internalTerm and nullTerm
+ * @param externalCode code necessary to produce externalTerm
+ * @param literalValue None if the expression is not literal. Otherwise it
represent the
+ * original object of the literal.
+ *
+ */
+class ExternalGeneratedExpression(
+ dataType: DataType,
+ internalTerm: String,
+ externalTerm: String,
+ nullTerm: String,
+ internalCode: String,
+ externalCode: String,
+ literalValue: Option[Any] = None)
+ extends GeneratedExpression(
+ internalTerm, nullTerm, internalCode, dataType.getLogicalType,
literalValue) {
+
+ def getExternalCode: String = externalCode
+
+ def getExternalTerm: String = externalTerm
+
+ def getDataType: DataType = dataType
+
+ override def copy(resultTerm: String, nullTerm: String,
Review comment:
If ExternalGeneratedExpression is not override copy method, it's copy
method will return the object that is the instance of GeneratedExpression
instead of ExternalGeneratedExpression, match {case external:
ExternalGeneratedExpression} will fail at BridgingFunctionGenUtil.scala#298 and
BridgingFunctionGenUtil.scala#308
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/ExternalGeneratedExpression.scala
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen
+
+import org.apache.flink.table.types.DataType
+import org.apache.flink.table.types.logical.LogicalType
+
+/**
+ * Describes a external generated expression.
+ *
+ * @param dataType type of the resultTerm
+ * @param internalTerm term to access the internal result of the expression
+ * @param externalTerm term to access the external result of the expression
+ * @param nullTerm boolean term that indicates if expression is null
+ * @param internalCode code necessary to produce internalTerm and nullTerm
+ * @param externalCode code necessary to produce externalTerm
+ * @param literalValue None if the expression is not literal. Otherwise it
represent the
+ * original object of the literal.
+ *
+ */
+class ExternalGeneratedExpression(
+ dataType: DataType,
+ internalTerm: String,
+ externalTerm: String,
+ nullTerm: String,
+ internalCode: String,
+ externalCode: String,
+ literalValue: Option[Any] = None)
+ extends GeneratedExpression(
+ internalTerm, nullTerm, internalCode, dataType.getLogicalType,
literalValue) {
+
+ def getExternalCode: String = externalCode
+
+ def getExternalTerm: String = externalTerm
+
+ def getDataType: DataType = dataType
+
+ override def copy(resultTerm: String, nullTerm: String,
Review comment:
@JingsongLi Do you have any better idea for this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
