zicat commented on a change in pull request #16163:
URL: https://github.com/apache/flink/pull/16163#discussion_r666066835
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/BridgingFunctionGenUtil.scala
##########
@@ -308,7 +315,12 @@ object BridgingFunctionGenUtil {
operands
.zip(argumentDataTypes)
.map { case (operand, dataType) =>
- operand.copy(resultTerm = genToExternalConverterAll(ctx, dataType,
operand))
+ operand match {
+ case external: ExternalGeneratedExpression
+ if !isInternal(dataType) && external.getDataType == dataType
+ => operand.copy(resultTerm = external.getExternalTerm, code =
external.getExternalCode)
Review comment:
@JingsongLi Master code changes a lot, I try to resolve conflicts,
Please help to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
