JingsongLi commented on a change in pull request #16349:
URL: https://github.com/apache/flink/pull/16349#discussion_r664356427
##########
File path: docs/layouts/shortcodes/generated/table_config_configuration.html
##########
@@ -22,7 +22,7 @@
</tr>
<tr>
<td><h5>table.generated-code.max-length</h5><br> <span
class="label label-primary">Batch</span> <span class="label
label-primary">Streaming</span></td>
- <td style="word-wrap: break-word;">64000</td>
+ <td style="word-wrap: break-word;">4000</td>
<td>Integer</td>
<td>Specifies a threshold where generated code will be split into
sub-function calls. Java has a maximum method length of 64 KB. This setting
allows for finer granularity if necessary.</td>
Review comment:
You need update `Java has a maximum method length of 64 KB` too. Why not
64K?
Add some description for `JIT` limitation?
##########
File path:
flink-table/flink-table-code-splitter/src/main/resources/META-INF/NOTICE
##########
@@ -1,4 +1,4 @@
-flink-table-code-splitter
+Flink : Table : Code Splitter
Review comment:
Why not `flink-table-code-splitter`?
##########
File path:
flink-table/flink-table-code-splitter/src/main/resources/META-INF/NOTICE
##########
@@ -7,7 +7,7 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the BSD 3-clause license.
See bundled license files for details.
-- antlr:4.7
+- org.antlr:antlr4-runtime:4.7
Review comment:
I took a look to
https://github.com/antlr/grammars-v4/blob/master/java/java/pom.xml#L4 for
`JavaLexer.g4`.
There should be two.
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/generated/GeneratedTableAggsHandleFunction.java
##########
@@ -18,12 +18,15 @@
package org.apache.flink.table.runtime.generated;
+import org.apache.flink.configuration.Configuration;
+
/** Describes a generated {@link TableAggsHandleFunction}. */
public class GeneratedTableAggsHandleFunction extends
GeneratedClass<TableAggsHandleFunction> {
private static final long serialVersionUID = 1L;
Review comment:
Maybe you should increase `serialVersionUID`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
