TsReaper commented on a change in pull request #16349:
URL: https://github.com/apache/flink/pull/16349#discussion_r664265037
##########
File path: flink-table/flink-table-planner-blink/pom.xml
##########
@@ -378,6 +378,8 @@ under the License.
<!--
flink-table-runtime-blink dependencies -->
<include>org.codehaus.janino:*</include>
+
<include>org.apache.flink:flink-table-code-splitter</include>
Review comment:
Runtime module currently does not have its own packaging process. As
Janino dependency is also packed here, I think we should add the dependency
here.
##########
File path:
flink-table/flink-table-code-splitter/src/main/resources/META-INF/NOTICE
##########
@@ -1,4 +1,4 @@
-flink-table-code-splitter
+Flink : Table : Code Splitter
Review comment:
Most of the notice files use module name instead of their artifact id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
