pnowojski commented on a change in pull request #16369:
URL: https://github.com/apache/flink/pull/16369#discussion_r663785166
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/MultipleInputITCase.scala
##########
@@ -182,6 +182,27 @@ class MultipleInputITCase(shuffleMode: String) extends
BatchTestBase {
)
}
+ @Test
+ def testManyInputs(): Unit = {
+ val rowType = new RowTypeInfo(INT_TYPE_INFO, STRING_TYPE_INFO)
+ val data = Seq(BatchTestBase.row(1, "test"))
+ val nullables: Array[Boolean] = Array(true, true)
+ registerCollection("left_table", data, rowType, "a, b", nullables)
+ registerCollection("right_table", data, rowType, "c, d", nullables)
+
+ val numInputs = 56
Review comment:
why do we have `56` and not `MAX_SUPPORTED_INPUT_COUNT`?
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/MultipleInputITCase.scala
##########
@@ -182,6 +182,27 @@ class MultipleInputITCase(shuffleMode: String) extends
BatchTestBase {
)
}
+ @Test
+ def testManyInputs(): Unit = {
+ val rowType = new RowTypeInfo(INT_TYPE_INFO, STRING_TYPE_INFO)
+ val data = Seq(BatchTestBase.row(1, "test"))
+ val nullables: Array[Boolean] = Array(true, true)
+ registerCollection("left_table", data, rowType, "a, b", nullables)
+ registerCollection("right_table", data, rowType, "c, d", nullables)
+
+ val numInputs = 56
Review comment:
Oh, I think I now fully understand it. There were two bugs:
1. The limit should be 63 instead of 64
2. And on top of that, `1 << inputCount` was causing that the code would
fail already with 32 inputs.
2. Is the reason why the user's query with 56 inputs was failing?
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/MultipleInputITCase.scala
##########
@@ -182,6 +182,27 @@ class MultipleInputITCase(shuffleMode: String) extends
BatchTestBase {
)
}
+ @Test
+ def testManyInputs(): Unit = {
+ val rowType = new RowTypeInfo(INT_TYPE_INFO, STRING_TYPE_INFO)
+ val data = Seq(BatchTestBase.row(1, "test"))
+ val nullables: Array[Boolean] = Array(true, true)
+ registerCollection("left_table", data, rowType, "a, b", nullables)
+ registerCollection("right_table", data, rowType, "c, d", nullables)
+
+ val numInputs = 56
Review comment:
Oh, I think I now fully understand it. There were two bugs:
1. The limit should be 63 instead of 64
2. And on top of that, `1 << inputCount` was causing that the code would
fail already with 32 inputs.
and the problem number 2. Is the reason why the user's query with 56 inputs
was failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
