Github user chobeat commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1996#discussion_r65084114
  
    --- Diff: 
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
 ---
    @@ -0,0 +1,167 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.ml.math.distributed
    +
    +import java.lang
    +
    +import breeze.linalg.{CSCMatrix => BreezeSparseMatrix, Matrix => 
BreezeMatrix, Vector => BreezeVector}
    +import org.apache.flink.api.common.functions.RichGroupReduceFunction
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.scala._
    +import org.apache.flink.ml.math.{Matrix => FlinkMatrix, _}
    +import org.apache.flink.util.Collector
    +import org.apache.flink.ml.math.Breeze._
    +import scala.collection.JavaConversions._
    +
    +/**
    +  *
    +  * @param numRowsOpt If None, will be calculated from the DataSet.
    +  * @param numColsOpt If None, will be calculated from the DataSet.
    +  */
    +class DistributedRowMatrix(data: DataSet[IndexedRow],
    +                           numRowsOpt: Option[Int] = None,
    +                           numColsOpt: Option[Int] = None)
    +    extends DistributedMatrix {
    +
    +  lazy val getNumRows: Int = numRowsOpt match {
    +    case Some(rows) => rows
    +    case None => data.count().toInt
    +  }
    +
    +  lazy val getNumCols: Int = numColsOpt match {
    +    case Some(cols) => cols
    +    case None => calcCols
    +  }
    --- End diff --
    
    Also I remember why we are using `Int` and not `Long`: local vectors and 
matrices use `Int` for indices and so we would need to modify them or 
reimplement them because these distributed matrices rely on local 
implementations for many tasks. So they are not an option right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to