rkhachatryan commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r668284397



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java
##########
@@ -647,7 +647,12 @@ private ResourceCounter 
tryFulfillRequirementsWithPendingSlots(
                     pendingSlots = allocationResult.getNewAvailableResources();
                     if (!allocationResult.isSuccessfulAllocating()
                             && sendNotEnoughResourceNotifications) {
-                        LOG.warn("Could not fulfill resource requirements of 
job {}.", jobId);
+                        // TODO (review): free slots are logged as zero here, 
but non-zero in
+                        // JobMaster.slotPoolService

Review comment:
       I see, I'll remove the TODO then.
   Thanks for clarifying.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to