tillrohrmann commented on a change in pull request #16457:
URL: https://github.com/apache/flink/pull/16457#discussion_r669357359
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java
##########
@@ -348,14 +348,17 @@ public void notifyNotEnoughResourcesAvailable(
Collection<ResourceRequirement> acquiredResources) {
assertRunningInMainThread();
- failPendingRequests();
+ failPendingRequests(acquiredResources);
}
- private void failPendingRequests() {
+ private void failPendingRequests(Collection<ResourceRequirement>
acquiredResources) {
if (!pendingRequests.isEmpty()) {
final NoResourceAvailableException cause =
new NoResourceAvailableException(
- "Could not acquire the minimum required
resources.");
+ "Could not acquire the minimum required resources.
Acquired: "
+ + acquiredResources
+ + ". Current slot pool status: "
+ + getSlotServiceStatus());
Review comment:
Printing `acquiredResources` can actually produce quite some text.
Hence, I am wondering whether we should really include this information in
every `NoResourceAvailableException` since it will be logged for every request
later on. Maybe it could be better to log it once in this method and then fail
the requests w/o this information.
```
log.info("Could not acquire the minimum required resources. Failing all
pending requests. Acquired {}. Current slot pool status: {}.",
acquiredResources, getSlotServiceStatus());
```
What do you think @rkhachatryan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
