Airblader commented on a change in pull request #16482:
URL: https://github.com/apache/flink/pull/16482#discussion_r669355297
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/config/StartupMode.java
##########
@@ -19,6 +19,8 @@
import org.apache.flink.annotation.Internal;
import
org.apache.flink.streaming.connectors.kafka.internals.KafkaTopicPartitionStateSentinel;
+import
org.apache.flink.streaming.connectors.kafka.table.KafkaConnectorOptions.ScanStartupMode;
+import org.apache.flink.table.api.TableException;
/** Startup modes for the Kafka Consumer. */
@Internal
Review comment:
This enum is basically a duplicate of `ScanStartupMode` now. Ideally I'd
just merge them, but this would expose the `stateSentinel` stuff in the API. Is
that OK or should we keep them separate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
