Airblader commented on a change in pull request #16482:
URL: https://github.com/apache/flink/pull/16482#discussion_r669366830
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSink.java
##########
@@ -330,7 +330,7 @@ public int hashCode() {
topic,
kafkaSerializer,
properties,
- FlinkKafkaProducer.Semantic.valueOf(semantic.toString()),
+ FlinkKafkaProducer.Semantic.valueOf(semantic.name()),
Review comment:
This isn't pretty, but wasn't before either. I can of course map
`KafkaSinkSemantic → Semantic` explicitly, but is there a reason these are
different enums in the first place? This was already the case since I didn't
create `KafkaSinkSemantic` in this PR but rather just used it in the connector
options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
