StephanEwen commented on a change in pull request #16486:
URL: https://github.com/apache/flink/pull/16486#discussion_r669642808
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolderTest.java
##########
@@ -601,6 +606,8 @@ protected void step() throws Exception {
private static final class FutureCompletedAfterSendingEventsCoordinator
extends CheckpointEventOrderTestBaseCoordinator {
+ private final OneShotLatch checkpointCompleted = new OneShotLatch();
+
@Nullable private CompletableFuture<byte[]> checkpoint;
Review comment:
Can do that, is also nice "documentation".
I think for correctness it is not relevant, since we don't rely on
happen-before visibility here. (And visibility will happen eventually anyways,
as in a few microseconds later).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
