tillrohrmann commented on a change in pull request #16486:
URL: https://github.com/apache/flink/pull/16486#discussion_r669421794



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolderTest.java
##########
@@ -601,6 +606,8 @@ protected void step() throws Exception {
     private static final class FutureCompletedAfterSendingEventsCoordinator
             extends CheckpointEventOrderTestBaseCoordinator {
 
+        private final OneShotLatch checkpointCompleted = new OneShotLatch();
+
         @Nullable private CompletableFuture<byte[]> checkpoint;

Review comment:
       Might not be super relevant, but we might save some cycles if we mark 
this field `volatile` since it is accessed from different threads.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to