zhuzhurk commented on a change in pull request #16436:
URL: https://github.com/apache/flink/pull/16436#discussion_r670184762
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java
##########
@@ -171,4 +177,30 @@ private static void connectPointwise(
}
}
}
+
+ private static ConsumedPartitionGroup
createAndRegisterConsumedPartitionGroupToEdgeManager(
+ IntermediateResultPartitionID consumedPartitionId,
+ IntermediateResult intermediateResult) {
+ ConsumedPartitionGroup consumedPartitionGroup =
+
ConsumedPartitionGroup.fromSinglePartition(consumedPartitionId);
+ intermediateResult
+ .getProducer()
+ .getGraph()
+ .getEdgeManager()
+ .registerConsumedPartitionGroup(consumedPartitionGroup);
+ return consumedPartitionGroup;
Review comment:
The method can be implemented as
`createAndRegisterConsumedPartitionGroupToEdgeManager(Collections.singleton(consumedPartitionId))`.
And maybe we can remove `ConsumedPartitionGroup#fromSinglePartition(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
