Thesharing commented on a change in pull request #16436:
URL: https://github.com/apache/flink/pull/16436#discussion_r670226746
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java
##########
@@ -171,4 +177,30 @@ private static void connectPointwise(
}
}
}
+
+ private static ConsumedPartitionGroup
createAndRegisterConsumedPartitionGroupToEdgeManager(
+ IntermediateResultPartitionID consumedPartitionId,
+ IntermediateResult intermediateResult) {
+ ConsumedPartitionGroup consumedPartitionGroup =
+
ConsumedPartitionGroup.fromSinglePartition(consumedPartitionId);
+ intermediateResult
+ .getProducer()
+ .getGraph()
+ .getEdgeManager()
+ .registerConsumedPartitionGroup(consumedPartitionGroup);
+ return consumedPartitionGroup;
Review comment:
`ConsumedPartitionGroup#fromMultiplePartitions(Collections.singleton(consumedPartitionId))`
seems a bit of hard to understand. We can refactor a method called
`registerConsumedPartitionGroupToEdgeManager`. This will make this method more
clear.
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adapter/DefaultResultPartitionTest.java
##########
@@ -34,24 +33,18 @@
/** Unit tests for {@link DefaultResultPartition}. */
public class DefaultResultPartitionTest extends TestLogger {
- private static final TestResultPartitionStateSupplier resultPartitionState
=
- new TestResultPartitionStateSupplier();
-
- private final IntermediateResultPartitionID resultPartitionId =
- new IntermediateResultPartitionID();
- private final IntermediateDataSetID intermediateResultId = new
IntermediateDataSetID();
+ @Test
Review comment:
Thank you for pointing this out. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
