pnowojski commented on a change in pull request #21:
URL: https://github.com/apache/flink-benchmarks/pull/21#discussion_r670291230



##########
File path: src/main/resources/log4j2-test.properties
##########
@@ -16,8 +16,13 @@
 # limitations under the License.
 
################################################################################
 
-log4j.rootLogger=WARN, console
+rootLogger.level = ERROR

Review comment:
       Have you checked how many error or warn messages are being currently 
produced? Having default warn/error would be great, as long as it doesn't skew 
the benchmark results. If it does, we would either need to set the level to 
`OFF` or invest a time into getting rid of those errors/warnings.
   
   The test run from the CI suggests that there were no messages printed at 
all? Could that be true?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to