pnowojski commented on a change in pull request #21:
URL: https://github.com/apache/flink-benchmarks/pull/21#discussion_r670291230
##########
File path: src/main/resources/log4j2-test.properties
##########
@@ -16,8 +16,13 @@
# limitations under the License.
################################################################################
-log4j.rootLogger=WARN, console
+rootLogger.level = ERROR
Review comment:
Have you checked how many error or warn messages are being currently
produced? Having default warn/error would be great, as long as it doesn't skew
the benchmark results. If it does, we would either need to set the level to
`OFF` or invest a time into getting rid of those errors/warnings.
The test run from the CI suggests that there were no messages printed at
all? Could that be true? I've also tried throwing some exception in the
submitted job code, but it looks like it's still not logging anything?
```
@Benchmark
public void asyncWait(FlinkEnvironmentContext context) throws Exception {
StreamExecutionEnvironment env = context.env;
env.enableCheckpointing(CHECKPOINT_INTERVAL_MS);
env.setParallelism(1);
DataStreamSource<Long> source = env.addSource(new
LongSource(RECORDS_PER_INVOCATION));
DataStream<Long> result = createAsyncOperator(source);
result.addSink(
new SinkFunction<Long>() {
@Override
public void invoke(Long value) throws Exception {
if (value == RECORDS_PER_INVOCATION / 2) {
throw new UnsupportedOperationException();
}
}
});
env.execute();
}
```
I mean it's not logging anything more compared to what it's logging if I set
level to OFF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
