zentol commented on pull request #22: URL: https://github.com/apache/flink-benchmarks/pull/22#issuecomment-880596880
So we run 1 benchmark with the current master + explicitly setting the number of slots to 4. If we don't see changes we can be pragmatic and always set the number of slots to 4, if we see changes we can look into modifying all benchmarks to set the number of slots. > An overloaded setUp(int taskSlots) method? That would require subclasses in each benchmark, no? Because the benchmarks extend the `BenchmarkBase`, not the `FlinkEnvironmentContext`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
