jinxing64 commented on a change in pull request #16118:
URL: https://github.com/apache/flink/pull/16118#discussion_r670380460



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTrackerImpl.java
##########
@@ -209,14 +228,22 @@ private static boolean isPartitionWithLocalResources(
                 .isPresent();
     }
 
-    private static Stream<ResultPartitionDeploymentDescriptor> 
excludePersistentPartitions(
+    private static Stream<ResultPartitionDeploymentDescriptor> 
excludePersistentAndLocalPartitions(

Review comment:
       ok, though I don't find a scenario in which an completed external 
partition occupies tm resource. Note that if we keep 
excludePersistentPartitions, shufflemaster might be fed with unknown partitionid




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to