jinxing64 commented on a change in pull request #16118:
URL: https://github.com/apache/flink/pull/16118#discussion_r670393641



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTrackerImplTest.java
##########
@@ -110,7 +113,8 @@ public void testReleaseCallsWithLocalResources() {
                         resultPartitionId2, true));
 
         {
-            
partitionTracker.stopTrackingAndReleasePartitionsFor(taskExecutorId1);
+            partitionTracker.stopTrackingAndReleasePartitions(

Review comment:
       Yes, I also had such concern but was hesitate to remove the existing 
testing block -- at least current code tests the process of un-tracking 
partitions one by one.
   
   Besides `testReleaseCallsWithoutLocalResources` also has the similar issue.
   Do you insists?  I can remove the block if so.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to