dmvk commented on a change in pull request #15501:
URL: https://github.com/apache/flink/pull/15501#discussion_r671397630
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionAndRetrievalITCase.java
##########
@@ -52,17 +60,28 @@ public void testLeaderElectionAndRetrieval() throws
Exception {
KubernetesLeaderElectionDriver leaderElectionDriver = null;
KubernetesLeaderRetrievalDriver leaderRetrievalDriver = null;
+ final FlinkKubeClient flinkKubeClient =
kubernetesResource.getFlinkKubeClient();
+ final Configuration configuration =
kubernetesResource.getConfiguration();
+
+ final String clusterId =
configuration.getString(KubernetesConfigOptions.CLUSTER_ID);
+ final KubernetesConfigMapSharedWatcher configMapSharedWatcher =
+ flinkKubeClient.createConfigMapSharedWatcher(
+ KubernetesUtils.getConfigMapLabels(
+ clusterId,
LABEL_CONFIGMAP_TYPE_HIGH_AVAILABILITY));
+ configMapSharedWatcher.run();
+ final ExecutorService watchExecutorService =
Executors.newCachedThreadPool();
Review comment:
I guess we either need to shut the pool down after tests are finished or
have a daemon thread factory, otherwise this might block jvm from being shut
down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
