dmvk commented on a change in pull request #15501: URL: https://github.com/apache/flink/pull/15501#discussion_r673719477
########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubernetesSharedWatcher.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.kubeclient; + +import org.apache.flink.kubernetes.kubeclient.FlinkKubeClient.WatchCallbackHandler; + +import javax.annotation.Nullable; + +import java.util.concurrent.ExecutorService; + +/** The interface for the Kubernetes shared watcher. */ +public interface KubernetesSharedWatcher<T> extends AutoCloseable { + + /** Run the shared watcher. */ + void run(); + + /** Close the shared watcher without Exception. */ + void close(); Review comment: ```suggestion @Override void close(); ``` ########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubernetesSharedWatcher.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.kubeclient; + +import org.apache.flink.kubernetes.kubeclient.FlinkKubeClient.WatchCallbackHandler; + +import javax.annotation.Nullable; + +import java.util.concurrent.ExecutorService; + +/** The interface for the Kubernetes shared watcher. */ +public interface KubernetesSharedWatcher<T> extends AutoCloseable { + + /** Run the shared watcher. */ + void run(); + + /** Close the shared watcher without Exception. */ + void close(); + + /** + * Watch the Kubernetes resource with specified name and do the {@link WatchCallbackHandler}. + * + * @param name name to filter the resource to watch + * @param callbackHandler callbackHandler which reacts to resource events + * @param executorService to run callback + * @return Return a watch for the Kubernetes resource. It needs to be closed after use. + */ + Watch watch( + String name, + WatchCallbackHandler<T> callbackHandler, + @Nullable ExecutorService executorService); + + /** The Watch returned after creating watching, which can be used to close the watching. */ + interface Watch { + void close(); Review comment: ```suggestion @Override void close(); ``` ########## File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityTestBase.java ########## @@ -119,6 +131,7 @@ public void teardown() throws Exception { } void runTest(RunnableWithException testMethod) throws Exception { + configMapSharedWatcher.run(); Review comment: Should we close this after the test finishes? ########## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubernetesSharedWatcher.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.kubeclient; + +import org.apache.flink.kubernetes.kubeclient.FlinkKubeClient.WatchCallbackHandler; + +import javax.annotation.Nullable; + +import java.util.concurrent.ExecutorService; + +/** The interface for the Kubernetes shared watcher. */ +public interface KubernetesSharedWatcher<T> extends AutoCloseable { + + /** Run the shared watcher. */ + void run(); + + /** Close the shared watcher without Exception. */ + void close(); + + /** + * Watch the Kubernetes resource with specified name and do the {@link WatchCallbackHandler}. + * + * @param name name to filter the resource to watch + * @param callbackHandler callbackHandler which reacts to resource events + * @param executorService to run callback + * @return Return a watch for the Kubernetes resource. It needs to be closed after use. + */ + Watch watch( + String name, + WatchCallbackHandler<T> callbackHandler, + @Nullable ExecutorService executorService); + + /** The Watch returned after creating watching, which can be used to close the watching. */ + interface Watch { Review comment: ```suggestion interface Watch extends AutoCloseable { ``` ########## File path: flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesHighAvailabilityTestBase.java ########## @@ -110,6 +117,11 @@ public void teardown() throws Exception { Context() { flinkKubeClient = createFlinkKubeClient(); + configMapSharedWatcher = + flinkKubeClient.createConfigMapSharedWatcher( + KubernetesUtils.getConfigMapLabels( + CLUSTER_ID, LABEL_CONFIGMAP_TYPE_HIGH_AVAILABILITY)); + watchExecutorService = Executors.newCachedThreadPool(); Review comment: Should we manage this service the same way as `org.apache.flink.kubernetes.highavailability.KubernetesHighAvailabilityTestBase#executorService`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
