twalthr commented on a change in pull request #16515:
URL: https://github.com/apache/flink/pull/16515#discussion_r672107230
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackend.java
##########
@@ -91,12 +91,6 @@
public class EmbeddedRocksDBStateBackend extends
AbstractManagedMemoryStateBackend
implements ConfigurableStateBackend {
- /** The options to chose for the type of priority queue state. */
- public enum PriorityQueueStateType {
Review comment:
yes, let's leave the enum there for now. The class is marked as
`PublicEvolving` but this is actually not correct. The RocksDB State Backend
has evolved to `Public` nowadays, so we need to be careful.
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/description/TextElement.java
##########
@@ -53,6 +55,11 @@ public static TextElement text(String text) {
return new TextElement(text, Collections.emptyList());
}
+ /** Wraps a list of {@link InlineElement}s into a single {@link
TextElement}. */
+ public static InlineElement wrap(List<InlineElement> elements) {
Review comment:
wouldn't be a vararg more handy?
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/description/TextElement.java
##########
@@ -53,6 +55,11 @@ public static TextElement text(String text) {
return new TextElement(text, Collections.emptyList());
}
+ /** Wraps a list of {@link InlineElement}s into a single {@link
TextElement}. */
+ public static InlineElement wrap(List<InlineElement> elements) {
Review comment:
btw we should add a test for it, it is not used anywhere in this PR
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
