Airblader commented on a change in pull request #16515:
URL: https://github.com/apache/flink/pull/16515#discussion_r673775404
##########
File path:
flink-docs/src/test/java/org/apache/flink/docs/configuration/ConfigOptionsDocsCompletenessITCase.java
##########
@@ -257,7 +254,7 @@ private static void compareDocumentedAndExistingOptions(
// Use split to exclude document key tag.
String key = tableRow.child(0).text().split("
")[0];
String defaultValue = tableRow.child(1).text();
- String typeValue = tableRow.child(2).text();
+ String typeValue = tableRow.child(2).html();
Review comment:
Here we're parsing the type from the current docs, and "on the other
side" we're generating it from the `ConfigOption`. Since there we do so by
calling `typeToHtml`, we need to also preserve the HTML here for the comparison
to work.
This happened to work previously because `#text()` preserves HTML in
`<p>A</p>B`, but not in `<p>A</p>` (for whatever reason).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
