rkhachatryan commented on a change in pull request #16531:
URL: https://github.com/apache/flink/pull/16531#discussion_r676114334
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -338,6 +338,9 @@ protected StreamTask(
Executors.newCachedThreadPool(
new ExecutorThreadFactory("AsyncOperations",
uncaughtExceptionHandler));
+ environment.setMainMailboxExecutor(mainMailboxExecutor);
+ environment.setAsyncOperationsThreadPool(asyncOperationsThreadPool);
Review comment:
Why isn't IO executor used here?
From its name, `asyncOperationsThreadPool` can be used for anything
including "control" actions (like declining checkpoints) or collecting metrics
- not only IO.
Though currently it is used for IO only - and that's why we should probably
merge the two, likely in favor of Tasks IO executor.
This will also allow to inject it via constructor and make the field
immutable.
WDYT?
cc: @pnowojski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
