rkhachatryan commented on a change in pull request #16531:
URL: https://github.com/apache/flink/pull/16531#discussion_r677172176
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -338,6 +338,9 @@ protected StreamTask(
Executors.newCachedThreadPool(
new ExecutorThreadFactory("AsyncOperations",
uncaughtExceptionHandler));
+ environment.setMainMailboxExecutor(mainMailboxExecutor);
+ environment.setAsyncOperationsThreadPool(asyncOperationsThreadPool);
Review comment:
> asyncOperationsThreadPool provides async snapshot workers for async
checkpoint runnable, which is exactly what we used for materialization in the
changelog case.
I think it's not exactly true - `asyncOperationsThreadPool` only waits for
snapshot completion, but upload can happen in other threads (which is the with
RocksDB).
Merging these pools is out of scope (if it happens), but should be taken
into account IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
