Myasuka commented on a change in pull request #16582: URL: https://github.com/apache/flink/pull/16582#discussion_r677268152
########## File path: flink-core/src/main/java/org/apache/flink/api/common/state/InternalCheckpointListener.java ########## @@ -0,0 +1,52 @@ +/* + +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. + +*/ + +package org.apache.flink.api.common.state; + +import org.apache.flink.annotation.Internal; + +/** + * The internal checkpoint listener add another {@link #notifyCheckpointSubsumed(long)} interface + * for internal usage. + */ +@Internal +public interface InternalCheckpointListener extends CheckpointListener { Review comment: My original idea is to add the new method in `CheckpointListener`. However, current `CheckpointListener` is already annotated as `public` and the semantics of a checkpoint subsumed should be acted as an internal operation only for runtime classes. Maybe we can see the relationship as `InternalKvState` and `State`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
