pnowojski commented on a change in pull request #16589:
URL: https://github.com/apache/flink/pull/16589#discussion_r678608700
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamMultipleInputProcessor.java
##########
@@ -84,8 +84,9 @@ public DataInputStatus processInput() throws Exception {
lastReadInputIndex = readingInputIndex;
DataInputStatus inputStatus =
inputProcessors[readingInputIndex].processInput();
+ inputSelectionHandler.updateStatus(inputStatus, readingInputIndex);
inputSelectionHandler.nextSelection();
- return inputSelectionHandler.updateStatus(inputStatus,
readingInputIndex);
+ return inputSelectionHandler.calculateOverallStatus(inputStatus);
Review comment:
In that case I have a feeling that those methods should be restructured,
maybe squashed together? More or less you could have kept the previous
structure of `updateStatus()` but move calling `nextSelection()` inside it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
