pnowojski commented on a change in pull request #16589:
URL: https://github.com/apache/flink/pull/16589#discussion_r678611406
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -203,8 +221,11 @@ private void updateAvailability() {
private void updateAvailability(
DataInputStatus status, StreamOneInputProcessor<?> input, int
inputIdx) {
- if (status == DataInputStatus.MORE_AVAILABLE
- || (status != DataInputStatus.END_OF_INPUT &&
input.isApproximatelyAvailable())) {
+ if (status == DataInputStatus.END_OF_DATA) {
+ inputSelectionHandler.setDataFinishedOnInput(inputIdx);
+ } else if (status == DataInputStatus.END_OF_INPUT) {
+ inputSelectionHandler.setEndOfPartition(inputIdx);
+ } else if (status == DataInputStatus.MORE_AVAILABLE ||
input.isApproximatelyAvailable()) {
Review comment:
That's fine. `input.isApproximatelyAvailable()` shouldn't be on the hot
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
