nicoweidner opened a new pull request #16654:
URL: https://github.com/apache/flink/pull/16654


   ## What is the purpose of the change
   
   This pull request changes 
JobVertexThreadInfoTrackerTest#testCachedStatsCleanedAfterCleanupInterval so 
that unfortunate timings no longer lead to potential failures.
   Before, if the provided JobVertexThreadInfoStats object was evicted from 
cache before we could fetch it, the test would fail. Now, we do not fetch it at 
all, but simply verify that one item was evicted from cache. 
   
   ## Brief change log
   - *JobVertexThreadInfoTracker can be instantiated with a provided Cache 
instance. If none is provided to JobVertexThreadInfoTrackerBuilder, it will use 
an identical one to that used so far*
   - *testCachedStatsCleanedAfterCleanupInterval uses this to configure the 
cache to track statistics and verify the eviction*
   - *unnecessary wait times in testCachedStatsCleanedAfterCleanupInterval and 
testCachedStatsUpdatedAfterRefreshInterval are reduced
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is already covered by existing tests, such as 
JobVertexThreadInfoTrackerTest.
   The instability was no longer observable locally.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to