tsreaper commented on a change in pull request #16650:
URL: https://github.com/apache/flink/pull/16650#discussion_r681666012
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala
##########
@@ -366,7 +366,7 @@ class AggFunctionFactory(
new LeadLagAggFunction.DoubleLeadLagAggFunction(argTypes.length)
case BOOLEAN =>
new LeadLagAggFunction.BooleanLeadLagAggFunction(argTypes.length)
- case VARCHAR =>
+ case VARCHAR | CHAR =>
new LeadLagAggFunction.StringLeadLagAggFunction(argTypes.length)
Review comment:
If you dig into the method you'll find out that the result of
`Table#printSchema` is from Calcite, not from the Flink SQL runtime. You can
also add a breakpoint in `LeadLagAggFunction
.StringLeadLagAggFunction#getResultType` and run this test to verify this. It
won't pause at the breakpoint.
In short, I still suggest you create a corresponding `LeadLagAggFunction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
