Airblader commented on a change in pull request #16691:
URL: https://github.com/apache/flink/pull/16691#discussion_r681743479
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/FunctionGenerator.scala
##########
@@ -784,6 +784,11 @@ class FunctionGenerator private(config: TableConfig) {
Seq(FLOAT, INTEGER),
BuiltInMethods.TRUNCATE_FLOAT)
+ addSqlFunctionMethod(JSON_EXISTS, Seq(CHAR, CHAR),
BuiltInMethods.JSON_EXISTS)
Review comment:
We don't really care about the specific argument types, only about the
number of arguments. However, `FunctionGenerator` uses a map of function +
argument types for the lookup, so we need to list the combinations. We
discussed extending `FunctionGenerator` to use a map with matchers instead of a
fixed set. I'm happy to make that change as a separate commit if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
