Airblader commented on a change in pull request #16691:
URL: https://github.com/apache/flink/pull/16691#discussion_r681744232
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -129,6 +129,8 @@ private static void testTableApiError(Table inputTable,
TableApiErrorTestItem te
try {
inputTable.select(testItem.expression).execute();
fail("Error expected: " + testItem.errorMessage);
+ } catch (AssertionError e) {
Review comment:
(If the `fail` call is reached, this will propagate that assertion
failure rather than running into the `catch` and then failing due to the
assertion on the (what is supposed to be the expected) exception)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
