PatrickRen commented on pull request #16551: URL: https://github.com/apache/flink/pull/16551#issuecomment-891863539
Thanks for the review @AHeise ! Sorry for misunderstanding the usage of ```junit-jupiter-migrationsupport```. I have removed them in the latest commit. About validating whether Jupiter engine is truly used, I tried to check the stack trace but found that the stack is different under different execution environments. For example Intellij IDEA has its own engine so I can't capture keyword "jupiter" in the stack trace. Instead I added a temp test class ```JUnitJupiterTest``` with JUnit5 unique features. I think this case can prove that Jupiter engine truly works in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
