PatrickRen commented on pull request #16551: URL: https://github.com/apache/flink/pull/16551#issuecomment-894343427
@AHeise Thanks again for the review! I made a rebase to sync with the latest master. I manually ran CI twice in my own AZP project, one with the JUnit 5 dependencies[1] and another without[2]. Number of tests are almost identical to each other (59,186 vs 59,189) only with slight diffs. Missing tests with JUnit5 dependencies: - org.apache.flink.testutils.junit.RetryRuleTest$TestClassWithAnnotation - org.apache.flink.testutils.junit.RetryRuleTest$TestClassWithAnnotationOnMethod - org.apache.flink.testutils.junit.RetryRuleTest$TestClassWithTestExpectingRuntimeException - org.apache.flink.testutils.junit.RetryRuleTest$TestClassWithoutAnnotation - org.apache.flink.test.checkpointing.LocalRecoveryITCase$EventTimeWindowCheckpointingITCaseInstance - org.apache.flink.api.common.typeutils.CompositeSerializerTest$CompositeSerializerTestInstance - org.apache.flink.api.java.typeutils.runtime.AbstractGenericTypeComparatorTest$ComparatorTestInstance - org.apache.flink.api.java.typeutils.runtime.EitherSerializerTest$EitherSerializerTestInstance - org.apache.flink.api.java.typeutils.runtime.LegacyRowSerializerTest$RowSerializerTestInstance - org.apache.flink.api.java.typeutils.runtime.RowSerializerTest$RowSerializerTestInstance Interesting thing is that all these tests are annotated with ```@Ignore```. Not sure why these cases are run in JUnit4. Additional tests with JUnit5 dependencies: - org.apache.flink.test.junit5.JUnitJupiterTest * 6 (Intentionally added for testing Jupiter engine) - org.apache.flink.connector.jdbc.xa.JdbcXaSinkMigrationTest#testCommitFromSnapshot (Not sure why this case is not run in JUnit4) In general, I think all test cases are covered with by vintage engine, and new Jupiter engine is validated by ```JUnitJupiterTest```. [1] With JUnit 5: https://dev.azure.com/renqs/Apache%20Flink/_build/results?buildId=42&view=ms.vss-test-web.build-test-results-tab [2] Without JUnit 5: https://dev.azure.com/renqs/Apache%20Flink/_build/results?buildId=43&view=ms.vss-test-web.build-test-results-tab -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
