AHeise commented on a change in pull request #16559:
URL: https://github.com/apache/flink/pull/16559#discussion_r683142635



##########
File path: 
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java
##########
@@ -52,8 +55,22 @@
     private final InternalWriteOperationHelper s3accessHelper;
 
     public HadoopS3AccessHelper(S3AFileSystem s3a, Configuration conf) {

Review comment:
       Yes, I think it would be best to have 2 commits ultimately.
   In the first one, you are bumping the hadoop version and adjust this class + 
license/notice files. In the second commit, your actual changes come in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to