dawidwys commented on a change in pull request #16655: URL: https://github.com/apache/flink/pull/16655#discussion_r683172235
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/FinishedOperatorSubtaskState.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint; + +/** + * A specialized {@link OperatorSubtaskState} used to mark the finished subtasks in the snapshot of + * this operator. + */ +public class FinishedOperatorSubtaskState extends OperatorSubtaskState { + + private static final long serialVersionUID = 7206415348825695023L; Review comment: Just use `1L`. Please take a look at our coding guidelines for explanation. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java ########## @@ -114,8 +115,14 @@ protected void serializeOperatorState(OperatorState operatorState, DataOutputStr operatorState.getSubtaskStates(); dos.writeInt(subtaskStateMap.size()); for (Map.Entry<Integer, OperatorSubtaskState> entry : subtaskStateMap.entrySet()) { - dos.writeInt(entry.getKey()); - serializeSubtaskState(entry.getValue(), dos); + if (entry.getValue().isFinished()) { + // We store a negative index for the finished subtask. In consideration + // of the index 0, the negative index would start from -1. + dos.writeInt(-(entry.getKey() + 1)); Review comment: That's a bit too much magic for my taste :( It kind of worked for `Operator` where it meant the number of enclosed states. Here I find too complex especially with the offsetting logic. Unfortunately, I think we need to adjust the metadata version. ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/FinishedOperatorSubtaskState.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint; + +/** + * A specialized {@link OperatorSubtaskState} used to mark the finished subtasks in the snapshot of + * this operator. + */ +public class FinishedOperatorSubtaskState extends OperatorSubtaskState { Review comment: Do we need a separate class? Could we just add a flag to the current class? ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java ########## @@ -347,6 +347,7 @@ public CompletedCheckpoint finalizeCheckpoint( } fulfillFullyFinishedOperatorStates(); + fulfillSubtaskStateForPartlyFinishedOperators(); Review comment: `Partly` -> `Partially` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
