dawidwys commented on a change in pull request #16655:
URL: https://github.com/apache/flink/pull/16655#discussion_r683185648
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java
##########
@@ -114,8 +115,14 @@ protected void serializeOperatorState(OperatorState
operatorState, DataOutputStr
operatorState.getSubtaskStates();
dos.writeInt(subtaskStateMap.size());
for (Map.Entry<Integer, OperatorSubtaskState> entry :
subtaskStateMap.entrySet()) {
- dos.writeInt(entry.getKey());
- serializeSubtaskState(entry.getValue(), dos);
+ if (entry.getValue().isFinished()) {
+ // We store a negative index for the finished subtask. In
consideration
+ // of the index 0, the negative index would start from -1.
+ dos.writeInt(-(entry.getKey() + 1));
Review comment:
@pnowojski @StephanEwen What do you think about adjusting the metadata
format to include the finished flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
