AHeise edited a comment on pull request #16551: URL: https://github.com/apache/flink/pull/16551#issuecomment-892586868
> Sorry for misunderstanding the usage of `junit-jupiter-migrationsupport`. I have removed them in the latest commit. Yes but I think you need to add `vintage` at some of those places (`migrationsupport` has it as a transitive dependency afaik) and now JUnit4 classes are missing. > About validating whether Jupiter engine is truly used, I tried to check the stack trace but found that the stack is different under different execution environments. For example Intellij IDEA has its own engine so I can't capture keyword "jupiter" in the stack trace. Instead I added a temp test class `JUnitJupiterTest` with JUnit5 unique features. I think this case can prove that Jupiter engine truly works in the project. Sounds good to me and is a neat idea. We can double-check if the test count is the same and your new test appears on AZP and then this PR is good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
