beyond1920 edited a comment on pull request #16669: URL: https://github.com/apache/flink/pull/16669#issuecomment-893974306
@cshuo Thanks for advices, however I prefer the first choice fr the following reason: 1. It's better to have a clear separation from WindowAggregate and old GroupWindowAggregate in planner level. In the feature, we may deprecate GroupWindowAggregate directly. I don't want to introduce unnecessary coupling here. 2. Routine the session window TVF directly to `StreamExecGroupWindowAggregate ` would limit some valid cases for session window TVF. For example, Session window aggregate followed by WindowRank or WindowJoin. 3. For cases which session window TVF currently not supported, I add strictly check in the planner, which would not lead to unexpected results. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
