beyond1920 edited a comment on pull request #16669: URL: https://github.com/apache/flink/pull/16669#issuecomment-894144352
@cshuo, Hi cshuo, I'm misunderstand your meaning before, sorry about that. Your second choice is translate to `StreamExecGroupWindowAggregate` in `StreamPhysicalWindowAggregate` for session window. So it would not effect the planner compatible. I agree with you, the second choice would remove the code deduplication. After we deprecate the `GroupWindowAggregate `, we add current code back, they would not be deduplicate code at that time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
