Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2093#discussion_r66787298
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/EventTimeTrigger.java
---
@@ -36,12 +36,17 @@ private EventTimeTrigger() {}
@Override
public TriggerResult onElement(Object element, long timestamp,
TimeWindow window, TriggerContext ctx) throws Exception {
ctx.registerEventTimeTimer(window.maxTimestamp());
- return TriggerResult.CONTINUE;
+
+ return (timestamp < ctx.getCurrentWatermark()) ?
--- End diff --
This should be `window.maxTimestamp() <= ctx.getCurrentWatermark()`. If the
tests pass with this, then they also need to be adapted to fail with the
current code and then work with the new code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
