Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2093#discussion_r66787877
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -264,7 +274,9 @@ public void dispose() {
@Override
@SuppressWarnings("unchecked")
public void processElement(StreamRecord<IN> element) throws Exception {
- Collection<W> elementWindows =
windowAssigner.assignWindows(element.getValue(), element.getTimestamp());
+
+ Collection<W> elementWindows = windowAssigner.
--- End diff --
Here I'm just being nitpicky but the code looks strange if broken into
lines like this. To me
```
Collection<W> elementWindows =
windowAssigner.assignWindows(element.getValue(),
element.getTimestamp());
```
or
```
Collection<W> elementWindows = windowAssigner.assignWindows(
element.getValue(),
element.getTimestamp());
```
seem more elegant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
