curcur commented on a change in pull request #16685:
URL: https://github.com/apache/flink/pull/16685#discussion_r684045760
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -153,20 +148,13 @@ private void logMetaIfNeeded() throws IOException {
out.writeInt(CURRENT_STATE_META_INFO_SNAPSHOT_VERSION);
StateMetaInfoSnapshotReadersWriters.getWriter()
.writeStateMetaInfoSnapshot(metaInfo.snapshot(), out);
- writeTtl(out);
+ writeMetadataDetails(out);
}));
metaDataWritten = true;
}
}
- private void writeTtl(DataOutputViewStreamWrapper out) throws IOException {
- out.writeBoolean(ttlConfig.isEnabled());
- if (ttlConfig.isEnabled()) {
- try (ObjectOutputStream o = new ObjectOutputStream(out)) {
- o.writeObject(ttlConfig);
- }
- }
- }
+ protected void writeMetadataDetails(DataOutputViewStreamWrapper out)
throws IOException {}
Review comment:
maybe change this name to writeMetaAndTtl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
